8000 add shipping method ups freight for get shipping rates by TusharSangani · Pull Request #64 · HotcakesCommerce/hotcakes-commerce-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add shipping method ups freight for get shipping rates #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2018
Merged

add shipping method ups freight for get shipping rates #64

merged 2 commits into from
Jan 25, 2018

Conversation

TusharSangani
Copy link
Contributor

add shipping method ups freight for get shipping rates

WillStrohl
WillStrohl requested changes Jan 23, 2018
View reviewed changes
Copy link
Member
@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to and/or address the comments in the code review and update your branch.

Libraries/Hotcakes.Commerce.NoCms/Hotcakes.Commerce.NoCms.csproj Outdated
<Reference Include="System.Web.Mvc, Version=4.0.0.1, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\packages\Microsoft.AspNet.Mvc.4.0.40804.0\lib\net40\System.Web.Mvc.dll</HintPath>
<Reference Include="System.Web.Mvc">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the MVC upgrade necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have reverted above change, when i have checkout project and try to build but it failed due to System.Web.Mvc.dll was missing so, i have used reference from nuget packages folder has latest version of MVC DLL(Microsoft.AspNet.Mvc.5.1.1) so, i have added reference of same.

Libraries/Hotcakes.Commerce/Hotcakes.Commerce.csproj Outdated
<Reference Include="System.Web.Mvc, Version=4.0.0.1, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\packages\Microsoft.AspNet.Mvc.4.0.40804.0\lib\net40\System.Web.Mvc.dll</HintPath>
<Reference Include="System.Web.Mvc">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the MVC upgrade necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have reverted above change, when i have checkout project and try to build but it failed due to System.Web.Mvc.dll was missing so, i have used reference from nuget packages folder has latest version of MVC DLL(Microsoft.AspNet.Mvc.5.1.1) so, i have added reference of same.

Libraries/Hotcakes.Shipping.UpsFreight/BillingOption.cs Outdated
@@ -0,0 +1,15 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the open source license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. added license header.

Libraries/Hotcakes.Shipping.UpsFreight/HandlineOneUnitType.cs Outdated
@@ -0,0 +1,21 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the open source license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. added license header.

Libraries/Hotcakes.Shipping.UpsFreight/PackingTypes.cs Outdated
@@ -0,0 +1,52 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the open source license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. added license header.

Libraries/Hotcakes.Shipping.UpsFreight/Properties/AssemblyInfo.cs Outdated
@@ -0,0 +1,36 @@
using System.Reflection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the open source license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,added license header.

Libraries/Hotcakes.Shipping.UpsFreight/ServiceTypes.cs Outdated
@@ -0,0 +1,21 @@
using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the open source license header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,added license header.

...sktopModules/Hotcakes/Core/Admin/Parts/Shipping/UPSFreight/App_LocalResources/Edit.ascx.resx Outdated
<data name="ShippingZone.Text" xml:space="preserve">
<value>Shipping Zone</value>
</data>
<data name="UPS10KgBox.Text" xml:space="preserve">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these standard UPS package and shipping keys/values necessary for the freight shipping method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have re-verify all keys and removed which are not used for freight shipping method.

@WillStrohl WillStrohl self-assigned this Jan 25, 2018
@WillStrohl WillStrohl merged commit 13223d4 into HotcakesCommerce:Issues/Issue-59 Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl requested changes

Assignees

@WillStrohl WillStrohl

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TusharSangani @WillStrohl
0