Make "Clear History" dialog taller #1857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the "Clear History" dialog slightly taller so all options can be visible. Fixes #1853
|
|
javifernandez
requested changes
May 14, 2025
| @@ -274,6 +274,9 @@ | |||
| <dimen name="settings_dialog_width">600dp</dimen> | |||
| <dimen name="settings_dialog_height">360dp</dimen> | |||
|
|
|||
| <!-- Language and voice settings --> | |||
| <dimen name="clear_history_height">400dp</dimen> | |||
There was a problem hiding this comment.
Is setting a fixed height the right approach ? We may have problems in the future if a SOP upgrade changes some if the UI styles. Cant we set the height to a dynamic value, so that it depends on the content ?
There was a problem hiding this comment.
I agree, fixed sizes are bad for interoperability among multiple devices. We probably need a scroll there...
There was a problem hiding this comment.
I'd rather avoid scroll if possible, using content-size height for the window, with a max-height that would enable scroll as you said, but only in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the "Clear History" dialog slightly taller
so all options can be visible.
Fixes #1853