Cleanup of VoiceSearchWidget #1886
Open
+83
−280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cf600b to
cd288fd
Compare
Additional checks to ensure that the voice recognition system is always in a consistent state.
Simplify the code of VoiceSearchWidget and make it respond better to state changes. The main change is to add a new State class that represents the state of the view and its associated message for the user. This allows us to simplify the layout while preserving the existing functionality.
cd288fd to
dfff9e1
Compare
svillar
reviewed
Jul 3, 2025
| @@ -219,16 +231,17 @@ public void onCanceled() { | |||
| @Override | |||
| public void onError(@ErrorType int errorType, @Nullable String error) { | |||
| Log.e(LOGTAG, "===> ERROR: " + error); | |||
| setResultState(errorType); | |||
| stopVoiceSearch(); | |||
There was a problem hiding this comment.
Would it make sense to call this in setState() instead? We could easily check if the new state is an error condition and stop the voice search there. Or are there cases in which setting an error state does not imply stopping the voice search?
There was a problem hiding this comment.
Currently, all error states stop the voice search.
Some errors are recoverable (e.g. the user remained silent) and some others are actual problems (e.g. the network is unavailable). If we continue evolving the UI, maybe in some cases we could try restarting the voice search.
In any case, the reason for having these two calls here is that setStateforError() only encapsulates UI changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code of VoiceSearchWidget and make it respond better to state changes.
The main change is to add a new State class that
represents the state of the view and its associated message for the user. This allows us to simplify the layout while preserving the existing functionality.