8000 Keyboard layout update by felipeerias · Pull Request #1887 · Igalia/wolvic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keyboard layout update #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Keyboard layout update #1887

merged 1 commit into from
Jul 4, 2025

Conversation

felipeerias
Copy link
Collaborator

Replace the vertical group of control buttons so each button may be positioned separately. This also required changes in hover management.

Use a slightly larger and more visible theming for the voice and close buttons.

Replace the keyboardMoveButton with a bar like the one that we use to move windows.

Update keyboard size calculations accordingly.

@felipeerias felipeerias force-pushed the felipeerias/keyboardLayoutUpdate branch from cdb4c60 to ddaf460 Compare July 3, 2025 06:12
Copy link
Member
@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the voice search commits in this PR, they should be orthogonal to this change.

The rest of the changes LGTM, so please upload a new version with just this commit and I'll approve it. Thanks!

Replace the vertical group of control buttons so each button
may be positioned separately. This also required changes in
hover management.

Use a slightly larger and more visible theming for the voice
and close buttons.

Replace the "keyboardMoveButton" with a bar like the one that
we use to move windows.

Update keyboard size calculations accordingly.
@felipeerias felipeerias force-pushed the felipeerias/keyboardLayoutUpdate branch from ddaf460 to 5968cf8 Compare July 4, 2025 11:43
@felipeerias felipeerias requested a review from svillar July 4, 2025 11:43
@felipeerias
Copy link
Collaborator Author

@svillar Thank you, I have updated the PR.

Copy link
Member
@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works great!

@svillar svillar merged commit 06fdd4b into main Jul 4, 2025
30 of 31 checks passed
@svillar svillar deleted the felipeerias/keyboardLayoutUpdate branch July 4, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0