feat(core): Replace compound arguments with specialized aggregate parser builders #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d82b30 to
d51c3f5
Compare
|
Does it have to be setup such that you first have to add the parsers to the ParserRegistry? I pretty much never use that cause I don't use annotations. Being able to set the types+parser directly instead of having to go through 1 extra step would be nice.- |
…ser builders fixes #711
d51c3f5 to
0c8cba4
Compare
|
I've added some factory methods that take ParserDescriptors, I'm not sure about adding even more methods to Command.Builder though. |
Citymonstret
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #711
also fixes the resulting type(token)s (literal
Pair<U extends Object, V extends Object>-> actual type iePair<String, Integer>)