8000 Fix dynamic defaults and predicate permissions being invoked with wrong sender types by jpenilla · Pull Request #728 · Incendo/cloud · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix dynamic defaults and predicate permissions being invoked with wrong sender types #728

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2024
Merged

Fix dynamic defaults and predicate permissions being invoked with wrong sender types #728

merged 5 commits into from
May 3, 2024

Conversation

jpenilla
Copy link
Member
@jpenilla jpenilla commented May 3, 2024

No description provided.

@jpenilla jpenilla linked an issue May 3, 2024 that may be closed by this pull request
ClassCastException when using dynamic default value and sender type #723
Closed
@jpenilla jpenilla requested a review from Citymonstret May 3, 2024 00:34
@github-actions GitHub Actions
Copy link
github-actions bot commented May 3, 2024 •
edited
Loading

Test Results

 85 files  ±0   85 suites  ±0   11s ⏱️ -3s
423 tests +3  423 ✅ +3  0 💤 ±0  0 ❌ ±0 
468 runs  +4  468 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 0dd5993. ± Comparison against base commit 81ac9f1.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both. 
org.incendo.cloud.caption.CaptionRegistryTest ‑ [23] caption=Caption{key=exception.invalid_syntax}

org.incendo.cloud.caption.CaptionRegistryTest ‑ [23] caption=Caption{key=exception.invalid_sender_list}
org.incendo.cloud.caption.CaptionRegistryTest ‑ [24] caption=Caption{key=exception.invalid_syntax}
org.incendo.cloud.feature.ChangedCommandSenderTypeTest ‑ testDynamicDefaults()
org.incendo.cloud.feature.ChangedCommandSenderTypeTest ‑ testPredicatePermissions()

♻️ This comment has been updated with latest results.

@jpenilla jpenilla added the 2.0.0 label May 3, 2024
Citymonstret
Citymonstret previously approved these changes May 3, 2024
View reviewed changes
@jpenilla jpenilla changed the title Sender type checks improvement Fix dynamic defaults and predicate permissions being invoked with wrong sender types May 3, 2024
@jpenilla jpenilla merged commit c1c3cd0 into master May 3, 2024
@jpenilla jpenilla deleted the sender-type-checks-improvement branch May 3, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Citymonstret Citymonstret Citymonstret left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClassCastException when using dynamic default value and sender type
2 participants
@jpenilla @Citymonstret
0