8000 feat: add lightness option by make-42 · Pull Request #153 · InioX/matugen · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add lightness option #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add lightness option #153

wants to merge 7 commits into from

Conversation

make-42
Copy link
@make-42 make-42 commented May 1, 2025 •
edited
Loading

Here is a proposed feature,

This PR would add a lightness option to adjust lightness of the outputted color scheme.

Here's a graph of how the lightness option affects the outputted lightnesses:
https://www.desmos.com/calculator/uagjexbi1x

This feature would allow stylix to have a lightness option if it switches to matugen as its color scheme generation engine:
nix-community/stylix#892

(in the original PR the lightnesses were adjusted post matugen but it's a bit hacky so it would be better to implement it upstream)

Thank you.

@make-42
Copy link
Author
make-42 commented May 1, 2025

Since people might want to adjust lightness for the dark and light schemes separately it might be worth it to have two separate arguments for each (especially since increasing the lightness past 1 for the dark scheme does nothing and decreasing the lightness past -1 for the light scheme does nothing as well)

@make-42
Copy link
Author
make-42 commented May 21, 2025

Here are some examples

Lightness scale dark: 0 (standard)
2025-05-21T21:38:36,122164948+02:00

Lightness scale dark: -0.05
2025-05-21T21:38:45,746692806+02:00

Lightness scale dark: -0.2
2025-05-21T21:38:58,938419489+02:00

Lightness scale dark: 0.2
2025-05-21T21:39:15,050270506+02:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@make-42 @make-42-2
0