8000 2325 annotation admin by ThieryMichel · Pull Request #2383 · Inist-CNRS/lodex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2325 annotation admin #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jan 27, 2025
Merged

2325 annotation admin #2383

merged 23 commits into from
Jan 27, 2025

Conversation

ThieryMichel
Copy link
Collaborator
@ThieryMichel ThieryMichel commented Jan 21, 2025
  • add annotation list on admin
  • allow to retrive the annotation resource with its title
  • display resource title
  • display resource link
  • display annotation createdAt
  • add tests

@ThieryMichel ThieryMichel added the 👷‍♂️ Work In Progress PR en cours de développement label Jan 21, 2025
@jonathanarnault jonathanarnault force-pushed the feat/2023-annotation-front branch from 48e3a7b to 958e31a Compare January 22, 2025 10:20
Base automatically changed from feat/2023-annotation-front to v15 January 23, 2025 13:34
@ThieryMichel ThieryMichel force-pushed the 2325-annotation-admin branch from 07998fc to 7ebd056 Compare January 23, 2025 14:33
"annotations" "Annotations" "Annotations"
"annotation.resourceId" "Resource title" "Titre de la ressource"
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
"annotation_query_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"

"annotation.resourceId" "Resource title" "Titre de la ressource"
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
"annotation.resource" "Resource" "Ressource"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick:

Suggested change
"annotation.resource" "Resource" "Ressource"
"annotation_resource" "Resource" "Ressource"

"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
"annotation.resource" "Resource" "Ressource"
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue This translation key is duplicated

"annotation.resource" "Resource" "Ressource"
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations"
"annotation.createdAt" "Submission date" "Date de soumission"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick

Suggested change
"annotation.createdAt" "Submission date" "Date de soumission"
"annotation_createdAt" "Submission date" "Date de soumission"

Comment on lines 34 to 40
const [page, setPage] = useState(0);
const [perPage, setPerPage] = useState(25);
const [sortBy, setSortBy] = useState('createdAt');
const [sortDir, setSortDir] = useState('desc');
const [filterBy, setFilterBy] = useState(null);
const [filterOperator, setFilterOperator] = useState(null);
const [filterValue, setFilterValue] = useState(null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Maybe it would be interesting to merge these states into one single state to ease maintainability ?

import OpenInNewIcon from '@mui/icons-material/OpenInNew';
import { DEFAULT_TENANT } from '../../../../common/tools/tenantTools';

const tenant = sessionStorage.getItem('lodex-tenant') || DEFAULT_TENANT;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: This line might case a problem with SSR as sessionStorage is not defined, isn't it ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe data is not loaded serverside, so this component is only rendered client side

@ThieryMichel ThieryMichel force-pushed the 2325-annotation-admin branch from 448c476 to be1b32a Compare January 24, 2025 15:59
@ThieryMichel ThieryMichel added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement labels Jan 24, 2025
@ThieryMichel ThieryMichel force-pushed the 2325-annotation-admin branch from be1b32a to 656d84d Compare January 24, 2025 16:01
@jonathanarnault jonathanarnault merged commit c94eefa into v15 Jan 27, 2025
6 checks passed
@jonathanarnault jonathanarnault deleted the 2325-annotation-admin branch January 27, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0