-
Notifications
You must be signed in to change notification settings - Fork 14
2325 annotation admin #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2325 annotation admin #2383
Conversation
48e3a7b
to
958e31a
Compare
07998fc
to
7ebd056
Compare
src/app/custom/translations.tsv
Outdated
"annotations" "Annotations" "Annotations" | ||
"annotation.resourceId" "Resource title" "Titre de la ressource" | ||
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" | |
"annotation_query_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" |
src/app/custom/translations.tsv
Outdated
"annotation.resourceId" "Resource title" "Titre de la ressource" | ||
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" | ||
"annotation.resource" "Resource" "Ressource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick:
"annotation.resource" "Resource" "Ressource" | |
"annotation_resource" "Resource" "Ressource" |
src/app/custom/translations.tsv
Outdated
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" | ||
"annotation.resource" "Resource" "Ressource" | ||
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue This translation key is duplicated
src/app/custom/translations.tsv
Outdated
"annotation.resource" "Resource" "Ressource" | ||
"annotation_qery_error" "Could not retrieve annotations" "Impossible de récupérer les annotations" | ||
"annotation.createdAt" "Submission date" "Date de soumission" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick
"annotation.createdAt" "Submission date" "Date de soumission" | |
"annotation_createdAt" "Submission date" "Date de soumission" |
const [page, setPage] = useState(0); | ||
const [perPage, setPerPage] = useState(25); | ||
const [sortBy, setSortBy] = useState('createdAt'); | ||
const [sortDir, setSortDir] = useState('desc'); | ||
const [filterBy, setFilterBy] = useState(null); | ||
const [filterOperator, setFilterOperator] = useState(null); | ||
const [filterValue, setFilterValue] = useState(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Maybe it would be interesting to merge these states into one single state to ease maintainability ?
import OpenInNewIcon from '@mui/icons-material/OpenInNew'; | ||
import { DEFAULT_TENANT } from '../../../../common/tools/tenantTools'; | ||
|
||
const tenant = sessionStorage.getItem('lodex-tenant') || DEFAULT_TENANT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: This line might case a problem with SSR as sessionStorage is not defined, isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe data is not loaded serverside, so this component is only rendered client side
448c476
to
be1b32a
Compare
be1b32a
to
656d84d
Compare
Uh oh!
There was an error while loading. Please reload this page.