2485 annotate field value #2492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitial value is a list
jonathanarnault
requested changes
Feb 7, 2025
src/app/custom/translations.tsv
Outdated
| @@ -1249,3 +1252,7 @@ | |||
| "annotation_status_ongoing" "Ongoing" "En cours" | |||
| "annotation_status_validated" "Validated" "Validée" | |||
| "annotation_status_rejected" "Rejected" "Refusée" | |||
| "annotation_correct_value" Correct "%{value}" "Corriger "%{value}" | |||
| "annotation_choose_value" "Choose value to comment" "Choisir la valeur à commenter" | |||
| "annotation_error_empty_initial_value" "This field must be empty when comment target the field" "Ce champ doit rester vide quant le commentaire cible le champ" | |||
There was a problem hiding this comment.
Suggested change
| "annotation_error_empty_initial_value" "This field must be empty when comment target the field" "Ce champ doit rester vide quant le commentaire cible le champ" | |
| "annotation_error_empty_initial_value" "This field must be empty when comment targets the field" "Ce champ doit rester vide quand le commentaire cible le champ" |
src/app/custom/translations.tsv
Outdated
| "annotation_correct_value" Correct "%{value}" "Corriger "%{value}" | ||
| "annotation_choose_value" "Choose value to comment" "Choisir la valeur à commenter" | ||
| "annotation_error_empty_initial_value" "This field must be empty when comment target the field" "Ce champ doit rester vide quant le commentaire cible le champ" | ||
| "annotation_error_required_initial_value" "This field is required when comment target the value" "Ce champ est requis quant le commentaire cible la valeur" |
There was a problem hiding this comment.
Suggested change
| "annotation_error_required_initial_value" "This field is required when comment target the value" "Ce champ est requis quant le commentaire cible la valeur" | |
| "annotation_error_required_initial_value" "This field is required when comment targets the value" "Ce champ est requis quand le commentaire cible la valeur" |
src/app/custom/translations.tsv
Outdated
| @@ -1249,3 +1252,7 @@ | |||
| "annotation_status_ongoing" "Ongoing" "En cours" | |||
| "annotation_status_validated" "Validated" "Validée" | |||
| "annotation_status_rejected" "Rejected" "Refusée" | |||
| "annotation_correct_value" Correct "%{value}" "Corriger "%{value}" | |||
There was a problem hiding this comment.
Suggested change
| "annotation_correct_value" Correct "%{value}" "Corriger "%{value}" | |
| "annotation_correct_value" "Correct %{value}" "Corriger %{value}" |
There was a problem hiding this comment.
Can you add tests for this file ?
There was a problem hiding this comment.
This component is straightforward and already tested through the CreateAnnotationModal component.
jonathanarnault
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2485
annotat value.webm
annotate targetvalue.webm
annotateField.webm
annotateChart.webm