-
Notifications
You must be signed in to change notification settings - Fork 14
2389 remove value #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
2389 remove value #2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanarnault
requested changes
Feb 10, 2025
active={isCurrentStepAuthorStep} | ||
/> | ||
<AuthorNameField form={form} /> | ||
<AuthorEmailField form={form} /> | ||
</Stack> | ||
)} | ||
</Box> | ||
|
||
<Box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick: Can you add spacing between previous and next buttons (justify-content: space-between
) ?
src/app/custom/translations.tsv
Outdated
"annotation_delete_button_label" "Delete the annotation" "Supprimer l'annotation" | ||
"annotation_delete_modal_title" "Are you sure you want to delete this annotation ?" "Êtes-vous sûr de vouloir supprimer cette annotation ?" | ||
"annotation_delete_success" "The annotation has been deleted." "L'annotation a été supprimée." | ||
"annotation_delete_error" "An error occured while deleteing this annotation, please try again later." "Une erreur est survenue lors de la supression de l'annotation, merci de réessayer ultérieurement." | ||
>>>>>>> 7dc52990c (Feat(annotation): Add annotation deletion support) | ||
"annotation_remove_content" "Remove some content" "Retirer du contenu" | ||
"removal" "Removal" "suppression" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"removal" "Removal" "suppression" | |
"removal" "Removal" "Suppression" |
jonathanarnault
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2389
annotation-remove-content.webm

