8000 2389 remove value by ThieryMichel · Pull Request #2504 · Inist-CNRS/lodex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2389 remove value #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 11, 2025
Merged

2389 remove value #2504

merged 20 commits into from
Feb 11, 2025

Conversation

ThieryMichel
Copy link
Collaborator
@ThieryMichel ThieryMichel commented Feb 10, 2025

@ThieryMichel ThieryMichel added the 👷‍♂️ Work In Progress PR en cours de développement label Feb 10, 2025
active={isCurrentStepAuthorStep}
/>
<AuthorNameField form={form} />
<AuthorEmailField form={form} />
</Stack>
)}
</Box>

<Box>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick: Can you add spacing between previous and next buttons (justify-content: space-between) ?

"annotation_delete_button_label" "Delete the annotation" "Supprimer l'annotation"
"annotation_delete_modal_title" "Are you sure you want to delete this annotation ?" "Êtes-vous sûr de vouloir supprimer cette annotation ?"
"annotation_delete_success" "The annotation has been deleted." "L'annotation a été supprimée."
"annotation_delete_error" "An error occured while deleteing this annotation, please try again later." "Une erreur est survenue lors de la supression de l'annotation, merci de réessayer ultérieurement."
>>>>>>> 7dc52990c (Feat(annotation): Add annotation deletion support)
"annotation_remove_content" "Remove some content" "Retirer du contenu"
"removal" "Removal" "suppression"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal" "Removal" "suppression"
"removal" "Removal" "Suppression"

@ThieryMichel ThieryMichel added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement labels Feb 10, 2025
@jonathanarnault jonathanarnault merged commit 4cb51cb into master Feb 11, 2025
8 checks passed
@jonathanarnault jonathanarnault deleted the 2389-remove-value branch February 11, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(1) En tant que contributeur, je souhaite suggérer un retrait d'une valeur dans un champ
2 participants
0