feat(theme): make Istex navigation bar configurable #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- Add navigation configuration in theme JSON files
- Update EJS template to use dynamic navigation items
- Allow up to 5 configurable menu items
- Add navigation configuration in theme JSON files - Update EJS template to use dynamic navigation items - Allow up to 5 configurable menu items
- Add fallback navigation items when no valid links are configured
touv
reviewed
Mar 27, 2025
| <% | ||
| let validLinks = 0; | ||
| if (custom.headerMenu) { | ||
| Object.keys(custom.headerMenu).slice(0, 4).forEach((key) => { |
There was a problem hiding this comment.
L'IA n'y a peut-être pas pensé mais dans ce type de cas, il me semble que l'usage de la fonction filter est plus explicite.
const validLinksArray = Object.keys(custom.headerMenu).slice(0, 4).filter(item => (item.url && item.name));
Le test suivant se fera sur la taille du tableau et la boucle d'après évitera de refaire deux fois les même traitements:
if (validLinksArray.length > 0) {
validLinksArray.forEach((key, idex) => {
%>
(...)
<%= validLinksArray[key].url %>
(...)
<% }); } else { %>
There was a problem hiding this comment.
Tu as raison, c’est une meilleure méthode. J’ai modifié le code pour faire ainsi !
…Menu information readme headerMenu documentation - theme istex version 7 -> 8
touv
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.