Use `vim.system(...)` instead of `vim.fn.system(...)` #27

HexoKnight · 2024-08-24T01:13:47Z

Description of changes

Essentially just replaced the vim.fn.system calls with improved vim.system calls.

The motivating reason was that (for a reason unbeknownst to me) vim.system calls cause the cursor to start blinking when running neovim specifically in the kitty terminal (works fine in xterm).

However, this also simplifies the code as it now bypasses the shell so should be entirely cross-platform and should not have any quoting issues. Although now vim.system errors if git isn't available so some extra error handling is required. I've only ever used lua in neovim snippets up until now so let me know if anything should have been done different.

Also it looks like neocord:get_buttons is unused but I changed the call there too in a different commit just for completeness.

Relevant Issues

None

CC Maintainers

@IogaMaster

for completeness

HexoKnight added 2 commits August 24, 2024 01:26

Replace vim.system with vim.fn.system

aac0440

Replace vim.system in neocord:get_buttons as well

0a6e0f2

for completeness

HexoKnight force-pushed the use-vim-system branch from 1d76845 to 0a6e0f2 Compare August 24, 2024 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use `vim.system(...)` instead of `vim.fn.system(...)` #27

Use `vim.system(...)` instead of `vim.fn.system(...)` #27

Uh oh!

Uh oh!

Uh oh!

Use vim.system(...) instead of vim.fn.system(...) #27

Are you sure you want to change the base?

Use vim.system(...) instead of vim.fn.system(...) #27

Uh oh!

Conversation

Description of changes

Relevant Issues

CC Maintainers

Uh oh!

Uh oh!

Use `vim.system(...)` instead of `vim.fn.system(...)` #27

Use `vim.system(...)` instead of `vim.fn.system(...)` #27