8000 Fix AArch64 syscall calling convention by linkmauve · Pull Request #65 · JakWai01/lurk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix AArch64 syscall calling convention #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix AArch64 syscall calling convention #65

wants to merge 1 commit into from

Conversation

linkmauve
Copy link

The previous code would only read the registers on exit, after the kernel has replaced the first argument with the result of the syscall, preventing us from displaying the correct arguments. It would also read the return code from x8 instead of x0, which contains the syscall number instead.

Makes ee731ca work at all. Also in the future please make reverts and feature additions into different commits.

Fixes #63.

@linkmauve
Fix AArch64 syscall calling convention
2f477da 
The previous code would only read the registers on exit, after the
kernel has replaced the first argument with the result of the syscall,
preventing us from displaying the correct arguments.  It would also read
the return code from x8 instead of x0, which contains the syscall number
instead.

Makes ee731ca work at all.  Also in the
future please make reverts and feature additions into different commits.

Fixes JakWai01#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken syscall arguments and return value on AArch64
1 participant
@linkmauve
0