-
Notifications
You must be signed in to change notification settings - Fork 32
Adding backend support #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding backend support #180
Conversation
}, | ||
body: JSON.stringify(obj) | ||
}) | ||
const put = await response.json(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
'Content-Type': 'application/json' | ||
}, | ||
body: JSON.stringify(obj) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
'defaultLibrary': document.getElementById('defaultLibrary').value | ||
} | ||
|
||
let response = await fetch(`/configuration/update/plex/library`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
'key': key, | ||
'enabled': document.getElementById('libraryEnabled').value, | ||
'defaultLibrary': document.getElementById('defaultLibrary').value | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} | ||
|
||
export async function savePlexLibraryConfiguration(machineIdentifier, key) { | ||
const obj = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'key': key | ||
} | ||
const plexLibraryButtonConfiguration = $("#plexLibraryButtonConfiguration").html(); | ||
const theTemplate = Handlebars.compile(plexLibraryButtonConfiguration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
const obj = { | ||
'machineIdentifier': machineIdentifier, | ||
'key': key | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
*/ | ||
|
||
export function openPlexLibraryConfigurationModel(machineIdentifier, key) { | ||
const obj = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
* | ||
*/ | ||
|
||
export function openPlexLibraryConfigurationModel(machineIdentifier, key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
@@ -20,6 +20,7 @@ import {saveEmailNotifications, testEmailNotifications} from "./modules/email-no | |||
import {saveSchedule} from "./modules/schedule.min.js"; | |||
import {getSoundOptions, savePushOverNotifications, testPushOverNotifications} from "./modules/push-over-notifications.min.js"; | |||
import {saveDiscordNotifications, testDiscordNotifications} from "./modules/discord-notifications.min.js"; | |||
import {openPlexLibraryConfigurationModel, savePlexLibraryConfiguration} from "./modules/plex-configuration.min.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
const plexLibraryModalTemplate = $("#plexLibraryModalTemplate").html(); | ||
const theTemplate = Handlebars.compile(plexLibraryModalTemplate); | ||
const theCompiledHtml = theTemplate(obj); | ||
const plexLibraryConfigurationModal = document.getElementById('plexLibraryConfigurationModal'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'key': key | ||
} | ||
const plexLibraryModalTemplate = $("#plexLibraryModalTemplate").html(); | ||
const theTemplate = Handlebars.compile(plexLibraryModalTemplate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
3b62c5d
to
d6545d3
Compare
.should('be.visible') | ||
.and(($img) => { | ||
// "naturalWidth" and "naturalHeight" are set when the image loads | ||
expect($img[0].naturalWidth).to.be.greaterThan(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
|
||
cy.get('.card-img') | ||
.should('be.visible') | ||
.and(($img) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
.should('be.visible') | ||
.and(($img) => { | ||
// "naturalWidth" and "naturalHeight" are set when the image loads | ||
expect($img[0].naturalWidth).to.be.greaterThan(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
|
||
cy.get('.card-img') | ||
.should('be.visible') | ||
.and(($img) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
cypress/integration/common.js
Outdated
.should('be.visible') | ||
.and(($img) => { | ||
// "naturalWidth" and "naturalHeight" are set when the image loads | ||
expect($img[0].naturalWidth).to.be.greaterThan(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
cypress/integration/common.js
Outdated
|
||
cy.get('.card-img') | ||
.should('be.visible') | ||
.and(($img) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
In progress