Add functions for adding/removing packages #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jguer
approved these changes
Apr 30, 2025
|
that's looking good @Kurstch , I've added some extra tests and fixed some issues with the linter in my last PR, if you can rebase, the CI should pass after |
|
I rebased, but there were some conflicts, so I ended up force pushing. Hope that is ok |
Jguer
approved these changes
May 1, 2025
|
All good, there's a minor linting problem but that's related to an update in golangci from yay-builder. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I want to use go-alpm for a hobby project, but I see that there's no support for package adding/removing.
This PR adds support for the following functions:
I also added minimal example in
testdata/examples/sync/sync.go(not sure if the name is appropriate).I did not include
alpm_trans_interruptcall in the example, because I do not fully understand how it works internally, and when it can be called.