8000 Adds support to AT32F403 (black pill) by rogerlz · Pull Request #284 · KalicoCrew/kalico · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds support to AT32F403 (black pill) #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 10, 2024
Merged

Adds support to AT32F403 (black pill) #284

merged 7 commits into from
Jun 10, 2024

Conversation

rogerlz
Copy link
Contributor
@rogerlz rogerlz commented May 30, 2024 •
edited
Loading

cherry-pick from @mattthebaker’s implementation with a few fixes to match the latest code

Thanks Matt.

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@rogerlz rogerlz requested a review from a team as a code owner May 30, 2024 10:15
@rogerlz rogerlz requested a review from mattthebaker May 30, 2024 12:32
@rogerlz rogerlz force-pushed the at32f403 branch 2 times, most recently from b56e226 to 57d615a Compare June 8, 2024 00:11
@EricZimmerman
Copy link

Checked out, built and flashed to supernova with black pill. Klipper started up fine. Will do test prints tomorrow

@comradef191 comradef191 mentioned this pull request Jun 9, 2024
Open
@dalegaard dalegaard self-requested a review June 10, 2024 13:39
dalegaard
dalegaard previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor
@dalegaard dalegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalegaard dalegaard removed the request for review from mattthebaker June 10, 2024 13:39
@rogerlz rogerlz merged commit f949975 into master Jun 10, 2024
2 checks passed
@rogerlz rogerlz deleted the at32f403 branch June 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalegaard dalegaard dalegaard left review comments

Assignees
No one assigned
Labels
ready-to-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rogerlz @EricZimmerman @dalegaard @mattthebaker
0