Fix rounding errors causing incorrect twinning #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to floating point imprecision, pairs of notes not to be considered twins, even though their differences are minor. This changes the twinning criteria to be based on time differences rather than naively using absolute time. More specifically, any two notes within 1ms of each other are considered twins. I am aware that this introduces potential degeneracy when > 2 notes are within 1ms the previous / next, causing all of them to be twinned, even though the maximal difference can be greater than 1ms. I will elect to ignore this, because that is just BS anyways, and it's better than not twinning when it is expected. HitObjectLines have gotten a similar treatment, but and in such a scenario the line will adopt the *median* start time. Same degeracy scenario applies and ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to floating point imprecision, pairs of notes may not to be considered twins, even though their differences are insignificant.
This changes the twinning criteria to be based on time differences rather than naively using absolute time. More specifically, any two notes within 1ms of each other are considered twins.
I am aware that this introduces potential degeneracy when > 2 notes are within 1ms of the previous/next note, causing all of them to be twinned, even though the maximal difference can be greater than 1ms. I have elected to ignore this, because that is just BS anyway, and it's better than not twinning when it is expected.
HitObject lines have got a similar treatment, and in such a scenario the line will adopt the median start time. Same degeneracy scenario applies and ignored.
PS: I wonder if anyone would notice if the HitObject lines are suddenly gone... 🤔