8000 [cleanup] Clean up unused scripts and files by BlankCheng · Pull Request #80 · LLM360/Reasoning360 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[cleanup] Clean up unused scripts and files #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Conversation

BlankCheng
Copy link
Collaborator

Clean up unused scripts and files for a neat main branch.

@BlankCheng BlankCheng requested a review from twkillian June 10, 2025 22:29
Copy link
Collaborator
@twkillian twkillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BlankCheng, this is a great effort to clean up old and no longer useful scripts.

I would however recommend that we either keep hold of some historical/archived scripts for different sizes of base models and/or algorithms as a reference for when someone wants to run smaller models (I, for one, don't always know what the correct number of nodes are to use for a specific model size) or use DAPO vs GRPO, etc.

If we don't want to keep around a small number of archived scripts, then we should include a guide in the README for how someone would adjust the launch script for their own experiment, etc.

In fact, there is a strong need to update the README anyway since the example runner file/configuration is being removed as well as the entire set of data preprocessing scripts. We need to indicate what is going on there and point to where the data is on each server.

Thanks!

@BlankCheng
Copy link
Collaborator Author

Hi, sure I'm writing README in another branch now and will PR when ready.
About history scripts, I backup them in another branch and will upload them soon, which is intended for more detailed scripts for experiments. On the main branch, maybe it's better to make it neat?

@BlankCheng BlankCheng merged commit eb76ae0 into main Jun 10, 2025
@BlankCheng BlankCheng deleted the zhoujun/cleanup branch June 11, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0