8000 fix saving json error for aime by AndreasXie · Pull Request #101 · LLM360/Reasoning360 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix saving json error for aime #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix saving json error for aime #101

merged 1 commit into from
Jun 24, 2025

Conversation

AndreasXie
Copy link
Collaborator

This pull request focuses on improving code consistency, readability, and functionality in the verl/trainer/main_generation.py file. Key changes include standardizing string quotation marks, simplifying logic for handling datasets, and removing redundant JSON export functionality for merged AIME responses.

Code Consistency and Readability:

  • Standardized all string quotation marks to double quotes for consistency across the file. [1] [2] [3] [4] [5] [6]

Dataset Handling:

  • Added a blank line for readability before returning a polars.DataFrame when converting datasets back to their original format.
  • Simplified logic for determining whether to merge AIME responses and for handling dataset exports in both polars and pandas formats.

Functionality Changes:

  • Removed redundant JSON export functionality for merged AIME responses, leaving only the parquet export. This streamlines the code and avoids unnecessary file generation.

These changes collectively enhance the maintainability and clarity of the codebase.

@AndreasXie AndreasXie requested a review from BlankCheng June 24, 2025 00:01
@BlankCheng
Copy link
Collaborator

LGTM!

@BlankCheng BlankCheng marked this pull request as ready for review June 24, 2025 22:05
@BlankCheng BlankCheng merged commit 86b5764 into main Jun 24, 2025
@BlankCheng BlankCheng deleted the fix_merge_aime branch June 25, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlankCheng BlankCheng BlankCheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasXie @BlankCheng
0