8000 use custom namespace for rapidjson to avoid sym collision by cyrush · Pull Request #743 · LLNL/conduit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use custom namespace for rapidjson to avoid sym collision #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

use custom namespace for rapidjson to avoid sym collision #743

merged 1 commit into from
Apr 16, 2021

Conversation

cyrush
Copy link
Member
@cyrush cyrush commented Apr 14, 2021

No description provided.

@cyrush
Copy link
Member Author
cyrush commented Apr 14, 2021

@xjrc change to fix collision issue. Is there a way to verify this fix solves the issue you saw?

@xjrc
Copy link
Member
xjrc commented Apr 14, 2021

@cyrush: Yes, I can run some tests this afternoon.

@cyrush
Copy link
Member Author
cyrush commented Apr 14, 2021

awesome, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.326% when pulling f24e93b on task/2021_04_rapidjson_namespace into 57702db on develop.

@xjrc xjrc self-requested a review April 15, 2021 22:12
xjrc
xjrc approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member
@xjrc xjrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyrush: I tested this out and it works! Thanks for getting to this so quickly.

@cyrush cyrush merged commit 1b012af into develop Apr 16, 2021
@cyrush cyrush deleted the task/2021_04_rapidjson_namespace branch April 16, 2021 21:27
@cyrush cyrush mentioned this pull request Apr 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjrc xjrc xjrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyrush @xjrc @coveralls
0