Watchflush #412
Merged
Watchflush #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaseleif , this isn't ready yet, but I just wanted to post it so you could see that I'm hacking on it. |
|
@chaseleif , Ok, I've at least tested the changes to flush file. I haven't done any testing regarding the changes to the watchdog. I'll think it's good to go, though please check that the watchdog still works if you're testing it. In reviewing how the watchdog is querying for the dataset location, there may be some bug in that we'll need to address. Part of that would be in the C code. I'll open an issue for it. |
|
Took a stab at poststage, but haven't bothered to test that either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move scr_flush_file commands from watchdog to the SCRFlushFile class.