8000 Test fixes by jameshcorbett · Pull Request #582 · LLNL/scr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test fixes #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Test fixes #582

merged 2 commits into from
Nov 28, 2023

Conversation

jameshcorbett
Copy link
Collaborator

Tracking down the sources of some test failures on elmerfudd.

Problem: the scr_run script has been moved and renamed,
but the 'run_test_py.sh' script still refers to it in
its old location.

Fix the usage in 'run_test_py.sh'.
Problem: the Flux and PBSALPS resourcemanager classes
have job_id methods that refer to a 'jobid' attribute that
may be unset. With Flux, the 'jobid' attribute was supposed to be
set in __init__ but this was removed by 9a697ce.

Fix the references to the 'jobid' attribute.
@adammoody adammoody merged commit 1878de8 into LLNL:develop Nov 28, 2023
@adammoody
Copy link
Contributor

Nice. Thanks, @jameshcorbett .

@jameshcorbett jameshcorbett deleted the test-fixes branch November 28, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0