8000 flipped the pressure names by jmpearl · Pull Request #253 · LLNL/spheral · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

flipped the pressure names #253

New issue
< 8000 div class="mt-3 mb-2 text-center">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

flipped the pressure names #253

merged 2 commits into from
Jan 16, 2024

Conversation

jmpearl
Copy link
Collaborator
@jmpearl jmpearl commented Jan 11, 2024 •
edited
Loading

Summary

  • This PR is a bugfix
  • It does the following:
    • damaged pressure and pressure were flipped in the first loop of FSI eval derivs. This led to incorrect decoupling between interface and damaged materail. This PR corrects that.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl jmpearl added this to the 2024.01.0 Release milestone Jan 11, 2024
@jmpearl jmpearl requested a review from jmikeowen January 12, 2024 20:05
jmikeowen
jmikeowen approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator
@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie! Yeah, that's a fun bug. This shouldn't have affected anything in the simulations I believe, but would be very confusing in the viz and diagnostics.

@jmpearl jmpearl merged commit 84e0bc6 into develop Jan 16, 2024
@jmpearl jmpearl deleted the bugFix/FSISPH branch January 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024.01.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jmpearl @jmikeowen
0