Bugfix MCS2 drivers: removed separate import MoveMode #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoep
requested changes
May 15, 2025
There was a problem hiding this comment.
Hi @ErikMaris
I just tried out running LabExT on my Mac (without the smaract package installed!) locally with these changes - however it does not start and outputs the error below. Would you mind checking if LabExT starts if you install it afresh on your computer?
Since these are type annotations anyhow that produce errors, we could just get rid of all of the type annotations that refer to the ctl module.
Thanks
Exception in thread Thread-1 (setup_runner):
Traceback (most recent call last):
File "/opt/miniconda3/envs/labext310/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/opt/miniconda3/envs/labext310/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "/Users/meppenberger/gitroot/LabExT/LabExT/ExperimentManager.py", line 215, in setup_runner
self.mover.import_stage_classes()
File "/Users/meppenberger/gitroot/LabExT/LabExT/Movement/MoverNew.py", line 193, in import_stage_classes
imported_stage_classes = self._plugin_loader.load_plugins(
File "/Users/meppenberger/gitroot/LabExT/LabExT/PluginLoader.py", line 65, in load_plugins
plugins = self.__load(path,
File "/Users/meppenberger/gitroot/LabExT/LabExT/PluginLoader.py", line 101, in __load
imported_module = import_module(".".join([package_name, name]))
File "/opt/miniconda3/envs/labext310/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/Users/meppenberger/gitroot/LabExT/LabExT/Movement/Stages/ChannelMCS2.py", line 8, in <module>
class ChannelMCS2:
File "/Users/meppenberger/gitroot/LabExT/LabExT/Movement/Stages/ChannelMCS2.py", line 134, in ChannelMCS2
def movement_mode(self) -> ctl.MoveMode:
AttributeError: 'NoneType' object has no attribute 'MoveMode'
marcoep
requested changes
May 15, 2025
There was a problem hiding this comment.
Hi @ErikMaris,
I added some suggested changes to remove all the type hints. Let me know if this works with your SmarAct MCS2 stage and I'll test locally again :)
Co-authored-by: Marco <github@mebg.ch>
Co-authored-by: Marco <github@mebg.ch>
Co-authored-by: Marco <github@mebg.ch>
Co-authored-by: Marco <github@mebg.ch>
Co-authored-by: Marco <github@mebg.ch>
|
Hi @marcoep Thanks for the suggestions--I have accepted them, and they work on my system :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the MCS2 drivers on a fresh install, the drivers failed without giving an error message. I traced this back to a failed import of
in LabExT/Movement/Stages/ChannelMCS2.py. Following the example from SmartAct, I removed the separate import of ModeMode, and called it directly from ctl as ctl.MoveMode. This fixed the problem in my test environment and on a fresh instal 8000 l from LabExt/dev.