8000 Remove unused logic for converting FilePro data to non-string types by sheesania · Pull Request #45 · LightSys/centrallix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused logic for converting FilePro data to non-string types #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: money_type
Choose a base branch
from
Open

Remove unused logic for converting FilePro data to non-string types #45

wants to merge 1 commit into from

Conversation

sheesania
Copy link
Contributor

Currently, the FilePro objectsystem driver only ever recognizes columns as type DATA_T_STRING, since there's no logic written yet for autodetecting other column types. This pull request removes logic for converting FilePro data to Centrallix object types other than DATA_T_STRING, since that code will currently never run in a real environment, in addition to removing a test that manually ran that logic.

Depends on #13

@sheesania sheesania requested a review from gbeeley July 23, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbeeley gbeeley Awaiting requested review from gbeeley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheesania
0