Update rt tests pi stress and cyclicdeadline #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcopeland
reviewed
May 9, 2025
| @@ -105,7 +103,7 @@ if [ "${ITERATIONS}" -gt 2 ]; then | |||
|
|
|||
| echo "Max allowed failures: $fail_limit" | |||
| echo "Actual failures: $fail_count" | |||
| echo "Number of max latencies above 1.${PTHRESHOLD}% of min: $fail_count" | |||
| echo "Number of max latencies above $min_latency of min: $fail_count" | |||
There was a problem hiding this comment.
I'd probably add the word baseline here.
above baseline ($)
|
LGTM apart from tiny bit of wording |
The pi-stress results shouldn't be based on the minimum value, it should be -X% from the max_inversion. Anything less than threshold is a fail. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Previously, the pi-stress script dynamically computed the baseline (minimum inversion value) across all iterations. This patch adds support for a new `-x` option that lets users manually specify a fixed `user_baseline` value. Using a fixed baseline is preferred over percentage-based thresholds in this context, as it offers more consistent and predictable evaluation—especially in controlled benchmarking environments or when comparing results across different systems and runs. Percentages can be misleading if the dynamic baseline fluctuates due to noise or system conditions. This change improves flexibility and repeatability in post-processing and performance analysis. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
15328f4 to
3f42086
Compare
Previously, the cyclicdeadline script dynamically computed the minimum latency value across all iterations. This patch introduces a new `-x` option that enables users to specify a fixed `user_baseline` value instead. Using a fixed baseline is preferred over percentage-based thresholds in this context, as it offers more consistent and predictable evaluation—especially in controlled benchmarking environments or when comparing results across different systems and runs. Percentages can be misleading if the dynamic baseline fluctuates due to noise or system conditions. This change improves flexibility and repeatability in post-processing and performance analysis. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
3f42086 to
834b2a3
Compare
bhcopeland
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.