-
Notifications
You must be signed in to change notification settings - Fork 121
android: add the Android KUnit test #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a comment about possible performance issue when parsing results in a LAVA job. Otherwise I see no issues.
--log-file-path="${DIR_TEST_LOGS}" \ | ||
-s "${ANDROID_SERIAL}" |& tee "${F_KUNIT_LOG}" | ||
|
||
parse_kunit_log "${F_KUNIT_LOG}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to do that in the postprocessing rather than in LAVA job. It dependes on how many results there are. If the number isn't too high, parsing in LAVA job is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the check! Yes, that's one of my concern as well, but consider currently there are only about 500 test case, it should be OK, maybe it's still OK after 10 times increased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
500 should be OK. I wouldn't go beyond 1k. LAVA is very slow when it comes to recording the results from the test job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I thought 5000 should be OK too:( Thanks for the information, I will keep an eye on it when deployed.
any idea about the Build docs error? or anyone could help to re-trigger it again ? |
@liuyq let me check. Doesn't seem related to the PR |
I can reproduce it with master branch as well. Will post a fix shortly. |
Thank you @mwasilew |
with the tests.zip package provided, which is generated by the normal gki kernel build Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
with the tests.zip package provided, which is generated by the normal gki kernel build