8000 android: add the Android KUnit test by liuyq · Pull Request #563 · Linaro/test-definitions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

android: add the Android KUnit test #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

liuyq
Copy link
Collaborator
@liuyq liuyq commented Apr 21, 2025

with the tests.zip package provided, which is generated by the normal gki kernel build

Copy link
Contributor
@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a comment about possible performance issue when parsing results in a LAVA job. Otherwise I see no issues.

--log-file-path="${DIR_TEST_LOGS}" \
-s "${ANDROID_SERIAL}" |& tee "${F_KUNIT_LOG}"

parse_kunit_log "${F_KUNIT_LOG}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to do that in the postprocessing rather than in LAVA job. It dependes on how many results there are. If the number isn't too high, parsing in LAVA job is fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check! Yes, that's one of my concern as well, but consider currently there are only about 500 test case, it should be OK, maybe it's still OK after 10 times increased.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

500 should be OK. I wouldn't go beyond 1k. LAVA is very slow when it comes to recording the results from the test job.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I thought 5000 should be OK too:( Thanks for the information, I will keep an eye on it when deployed.

@liuyq
Copy link
Collaborator Author
liuyq commented Apr 29, 2025

any idea about the Build docs error? or anyone could help to re-trigger it again ?

@mwasilew
Copy link
Contributor

@liuyq let me check. Doesn't seem related to the PR

@mwasilew
Copy link
Contributor

I can reproduce it with master branch as well. Will post a fix shortly.

@roxell
Copy link
Collaborator
roxell commented Apr 29, 2025

I can reproduce it with master branch as well. Will post a fix shortly.

Thank you @mwasilew

with the tests.zip package provided, which is generated
by the normal gki kernel build

Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
@bhcopeland bhcopeland merged commit eb8be1a into Linaro:master Apr 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0