8000 Fix double tap to save account by Balanced02 · Pull Request #1864 · LiskHQ/lisk-mobile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix double tap to save account #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Balanced02
Copy link
Contributor
@Balanced02 Balanced02 commented Jun 5, 2023

What was the problem?

This PR resolves #1843 #1844

How was it solved?

  • Changed validation mode of useForm to 'onChange'
  • Added KeyboardAwareScrollView to fix keyboard overlaying inputs

How was it tested?

iOS and Android simulator

@Balanced02 Balanced02 requested a review from clemente-xyz June 5, 2023 09:14
@Balanced02 Balanced02 self-assigned this Jun 5, 2023
@clemente-xyz
Copy link
Member

please point to release/3.0.0 branch!

@Balanced02 Balanced02 changed the base branch from development to release/3.0.0 June 5, 2023 09:24
@Balanced02 Balanced02 merged commit 1acd2d0 into release/3.0.0 Jun 5, 2023
@Balanced02 Balanced02 deleted the 1843-bufix/doubletab-account-creation branch June 5, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Users have to double tap save account
2 participants
0