Implement data access audit for Android app #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #1901
How was it solved?
Build a monitoring system to log when user's private data is accessed by the Lisk Android application.
This was done by implementing an Android native module named
AppOpsManagerModule, which makes use of Android's nativeAppOpsManagerAPI (official Android data access auditing feature) to log viaadbwhen private data has been accessed.Here a demonstration of the monitoring system working:
android.access.to.photos.webm
where the log outputted was:
Restrict access to resources is already being done on our Android manifest declaration (
android/app/src/main/AndroidManifest.xmlfile), where we only list the resources Lisk needs for its use cases. Data access not required by Lisk use cases are restricted here just by not specifying them. The current data access specification we are doing is:How was it tested?