10000 Bugfix: iOS: filesystem encryption is not enabled for locked devices by Balanced02 · Pull Request #1913 · LiskHQ/lisk-mobile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix: iOS: filesystem encryption is not enabled for locked devices #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

Bugfix: iOS: filesystem encryption is not enabled for locked devices #1913

merged 1 commit into from
Jul 6, 2023

Conversation

Balanced02
Copy link
Contributor
@Balanced02 Balanced02 commented Jul 5, 2023 •
edited
Loading

What was the problem?

This PR resolves #1900

How was it solved?

  • Add data protection to iOS Signing capabilities
  • Added Entitlements.plist file with needed key

How was it tested?

IOS Simulator

@Balanced02 Balanced02 requested a review from clemente-xyz July 5, 2023 16:01
@Balanced02 Balanced02 changed the base branch from development to release/3.0.0 July 5, 2023 16:01
ManuGowda
ManuGowda approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor
@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the steps in PR how you fixed so thats its useful for reviewers to understand?

@Balanced02 Balanced02 self-assigned this Jul 6, 2023
@Balanced02 Balanced02 merged commit 7194b3f into release/3.0.0 Jul 6, 2023
@ManuGowda ManuGowda deleted the 1900-file-encryption-ios branch July 6, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@clemente-xyz clemente-xyz clemente-xyz approved these changes

Assignees

@Balanced02 Balanced02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile iOS application: filesystem encryption is not enabled for locked devices
3 participants
@Balanced02 @ManuGowda @clemente-xyz
0