10000 build(homebrew): temporarily use miniupnpc head by ReenigneArcher · Pull Request #3952 · LizardByte/Sunshine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(homebrew): temporarily use miniupnpc head #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

build(homebrew): temporarily use miniupnpc head #3952

merged 1 commit into from
Jun 8, 2025

Conversation

ReenigneArcher
Copy link
Member
@ReenigneArcher ReenigneArcher commented Jun 7, 2025 •
edited
Loading

Description

This PR fixes build errors on homebrew when using miniupnpc 2.3.3

See:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the deps/homebrew/temporarily-use-miniupnpc-head branch from bc02489 to dcc5d98 Compare June 7, 2025 22:43
@ReenigneArcher ReenigneArcher changed the title deps/homebrew/temporarily use miniupnpc head deps(homebrew): temporarily use miniupnpc head Jun 7, 2025
@ReenigneArcher ReenigneArcher changed the title deps(homebrew): temporarily use miniupnpc head build(homebrew): temporarily use miniupnpc head Jun 7, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.41%. Comparing base (eaa434a) to head (126f427).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #3952     +/-   ##
=========================================
  Coverage   11.41%   11.41%             
=========================================
  Files          92       92             
  Lines       17493    17493             
  Branches     8180     8180             
=========================================
  Hits         1996     1996             
+ Misses      14811    13025   -1786     
- Partials      686     2472   +1786
Flag Coverage Δ
Linux 11.14% <ø> (ø)
Windows 12.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@codecov Codecov
Copy link
codecov bot commented Jun 7, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the deps/homebrew/temporarily-use-miniupnpc-head branch 2 times, most recently from 53d61ce to 6c9321d Compare June 7, 2025 23:49
@ReenigneArcher ReenigneArcher marked this pull request as ready for review June 8, 2025 00:05
@ReenigneArcher ReenigneArcher force-pushed the deps/homebrew/temporarily-use-miniupnpc-head branch 2 times, most recently from 8601ab6 to 0364f85 Compare June 8, 2025 00:32
@ReenigneArcher ReenigneArcher force-pushed the deps/homebrew/temporarily-use-miniupnpc-head branch from 0364f85 to 126f427 Compare June 8, 2025 00:52
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Jun 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) June 8, 2025 01:07
@ReenigneArcher ReenigneArcher merged commit 0a98094 into master Jun 8, 2025
40 checks passed
@ReenigneArcher ReenigneArcher deleted the deps/homebrew/temporarily-use-miniupnpc-head branch June 8, 2025 01:29
ReenigneArcher referenced this pull request in Homebrew/homebrew-core Jun 8, 2025
@BrewTestBot
miniupnpc: update 2.3.3 bottle.
d6030ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReenigneArcher
0