8000 [Bug]: Captures getting stuck on "The capture is ongoing. Please wait..." · Issue #1038 · Lookyloo/lookyloo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Bug]: Captures getting stuck on "The capture is ongoing. Please wait..." #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeroengui opened this issue May 18, 2025 · 7 comments
Closed

[Bug]: Captures getting stuck on "The capture is ongoing. Please wait..." #1038

jeroengui opened this issue May 18, 2025 · 7 comments
Assignees
@Rafiot
Labels
Bug

Comments

@jeroengui
Copy link
Contributor

What happened?

Captures are getting stuck on "The capture is ongoing. Please wait..."

Both when submitted via the api, as via the web interface. (version: commit fc3bac0)

I don't know on which version of Lookyloo this started, unfortunately.

Errors seen in lookyloo_message.log attached below.

If the issue is related to the web interface, what browsers are you seeing the problem on?

No response

Relevant log output

2025-05-18 07:59:13,693 Archiver ERROR:Something went terribly wrong in Archiver.
Traceback (most recent call last):
  File "/home/jeroengui/lookyloo/lookyloo/lookyloo/default/abstractmanager.py", line 149, in run
    self._to_run_forever()
  File "/home/jeroengui/lookyloo/lookyloo/bin/archiver.py", line 59, in _to_run_forever
    self.s3fs_client.clear_instance_cache()
    ^^^^^^^^^^^^^^^^
AttributeError: 'Archiver' object has no attribute 's3fs_client'


2025-05-18 08:31:06,750 LacusCore WARNING:[b1754c34-a994-4b0a-81c5-7187f7f50426] Unable to capture: No capture settings for b1754c34-a994-4b0a-81c5-7187f7f50426
2025-05-18 08:31:06,751 LacusCore ERROR:[b1754c34-a994-4b0a-81c5-7187f7f50426] Capture raised an uncaught exception
Traceback (most recent call last):
  File "/home/jeroengui/.cache/pypoetry/virtualenvs/lookyloo-yu5kPJMF-py3.12/lib/python3.12/site-packages/lacuscore/task_logger.py", line 51, in _handle_task_result
    task.result()
  File "/home/jeroengui/.cache/pypoetry/virtualenvs/lookyloo-yu5kPJMF-py3.12/lib/python3.12/site-packages/lacuscore/lacuscore.py", line 646, in _capture
    if to_capture.document:
       ^^^^^^^^^^
UnboundLocalError: cannot access local variable 'to_capture' where it is not associated with a value
@jeroengui jeroengui added the Bug label May 18, 2025
@jeroengui
Copy link
Contributor Author

This only seems to happen on Lookyloo installs that don't have a remote_lacus instance configured.

@Rafiot
Copy link
Member
Rafiot commented May 18, 2025

Right, I haven't tested lookyloo without a remote lacus configured recently, sorry for that. I'll have a look at it today or tomorrow.

The issue with the archiver should also not happen, same, I'll have a look at it.

@Rafiot Rafiot self-assigned this May 18, 2025
Rafiot added a commit to ail-project/LacusCore that referenced this issue May 18, 2025
@Rafiot
fix: Avoid exception when the capture has no settings
e31f6a1 
Related Lookyloo/lookyloo#1038
Rafiot added a commit that referenced this issue May 18, 2025
@Rafiot
fix: Exception when archives aren't on s3
e5c9782 
Related #1038
@Rafiot
Copy link
Member
Rafiot commented May 18, 2025

Both exceptions should be fixed, the one in lacuscore will require a new package (which I cannot do just yet). I haven't tested lookyloo without a remote lacus at this point.

@Rafiot
Copy link
Member
Rafiot commented May 18, 2025 •
edited
Loading

Alright, got it... That will teach me to treat a recurring error in the CI as a flaky test failing. I'll have it sorted very soon but probably not today.

It is due to that commit: ail-project/LacusCore@a8767c2

That will always cause the capture to fail if you're not using a remote lacus. Sorry for that.

< 8000 span class="TimelineItem-badge">
Rafiot added a commit that referenced this issue May 18, 2025
@Rafiot
fix: make sure the tasks are started before checking the status
1c8b2ff 
Related #1038
@Rafiot
Copy link
Member
Rafiot commented May 18, 2025

I think that one alone fixes it: 1c8b2ff

tl;dr: create_task doesn't seem to launch as immediately as I thought they were.

@Rafiot
Copy link
Member
Rafiot commented May 19, 2025

Seems fixed, let me know if you still have issues.

@Rafiot Rafiot closed this as completed May 19, 2025
@Rafiot
Copy link
Member
Rafiot commented May 19, 2025

For completeness, and because I didn't like the fix above, here is the actual final fix: ail-project/LacusCore@1e024a5

This was referenced May 19, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rafiot Rafiot

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rafiot @jeroengui
0