8000 Bump version by CBroz1 · Pull Request #1316 · LorenFrankLab/spyglass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump version #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump version #1316

wants to merge 1 commit into from
+19 −47

Conversation

CBroz1
Copy link
Member
@CBroz1 CBroz1 commented May 27, 2025

Description

Preparing for release 0.5.5. Release notes...

This release feature several features that require updating tables. Please contact admin via GitHub discussions if you have any questions.

# -- For recompute --
import datajoint as dj
from spyglass.spikesorting.v1 import recording as v1rec  # noqa
from spyglass.spikesorting.v0 import spikesorting_recording as v0rec  # noqa
from spyglass.linearization.v1.main import TrackGraph  # noqa

dj.FreeTable(dj.conn(), "common_nwbfile.analysis_nwbfile_log").drop()
dj.FreeTable(dj.conn(), "common_session.session_group").drop()
TrackGraph.alter()  # Add edge map parameter
v0rec.SpikeSortingRecording().alter()
v0rec.SpikeSortingRecording().update_ids()
v1rec.SpikeSortingRecording().alter()
v1rec.SpikeSortingRecording().update_ids()

# -- For LFP pipeline --
from spyglass.lfp.lfp_imported import ImportedLFP
from spyglass.lfp.lfp_merge import LFPOutput

if len(ImportedLFP()) or len(LFPOutput.ImportedLFP()):
    raise ValueError(
        "Existing entries found and would be dropped in update. Please delete "
        + "entries or start a GitHub discussion for migration assistance."
        + f"\nImportedLFP: {len(ImportedLFP())}"
        + f"\nLFPOutput.ImportedLFP: {len(LFPOutput.ImportedLFP())}"
    )

table = LFPOutput().ImportedLFP()
table_name = table.full_table_name

if len(drop_list := table.connection.dependencies.descendants(table_name)) > 1:
    drop_list = [x for x in drop_list if x != table_name]
    raise ValueError(
        "Downstream tables exist and would be dropped in update."
        + "Please drop the following tables first: \n"
        + "\n ".join([str(t) for t in drop_list])
    )

LFPOutput().ImportedLFP().drop_quick()
ImportedLFP().drop()

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • n/a This PR makes edits to table definitions: (yes/no)
  • n/a If table edits, I have included an alter snippet for release notes.
  • n/a If this PR makes changes to position, I ran the relevant tests locally.
  • n/a I have updated the CHANGELOG.md with PR number and description.
  • n/a I have added/edited docs/notebooks to reflect the changes

@codecov Codecov
Copy link
codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (8700d3e) to head (b874106).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files          98       98           
  Lines       12256    12256           
=======================================
  Hits         8238     8238           
  Misses       4018     4018

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CBroz1
0