8000 DLC updates by emreybroyles · Pull Request #1339 · LorenFrankLab/spyglass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DLC updates #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Conversation

emreybroyles
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context. Please list issues fixed or closed by
This PR.

  • Fixes #000: updating info for how to use the notebooks, and fixing parts that were breaking
    • /spyglass/notebooks/21_DLC.ipynb: updated that the env used is spyglass-dlc which is installed from environment_dlc.yml; fixes the error in pose estimation section where 'model_key' is not defined by creating an instance of dlc_pose_estimation before creating variable pose_estimation_key
    • /spyglass/notebooks/22_DLC_Loop.ipynb: same as above

Checklist:

  • This PR should be accompanied by a release: NO
  • If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: NO
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edeno edeno requested review from Copilot and CBroz1 June 26, 2025 17:19
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the DeepLabCut tutorial notebooks to use the spyglass-dlc environment, clear stale outputs/execution counts, and fix an undefined model_key error by instantiating the pose‐estimation class before inserting tasks.

  • Updated Conda environment notes from spyglass-position to spyglass-dlc
  • Reset execution_count to null and cleared cell outputs
  • Fixed NameError: model_key by creating a DLCPoseEstimationSelection instance before calling insert_estimation_task

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
notebooks/21_DLC.ipynb Environment note update; cleared outputs/execution counts
notebooks/22_DLC_Loop.ipynb Same notebook-level updates + instantiation fix for pose estimation

Comment on lines +172 to +174
"source": [
"### Body Parts"
]
Copy link
Preview
Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This markdown header appears twice in succession. Consider removing the duplicate to avoid repetition.

Suggested change
"source": [
"### Body Parts"
]
"source": []

Copilot uses AI. Check for mistakes.

Copy link
codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (2eb0ee1) to head (e1a8046).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
+ Coverage   67.21%   67.45%   +0.23%     
==========================================
  Files          98       98              
  Lines       12272    12290      +18     
==========================================
+ Hits         8249     8290      +41     
+ Misses       4023     4000      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0