-
Notifications
You must be signed in to change notification settings - Fork 49
DLC updates #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DLC updates #1339
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the DeepLabCut tutorial notebooks to use the spyglass-dlc
environment, clear stale outputs/execution counts, and fix an undefined model_key
error by instantiating the pose‐estimation class before inserting tasks.
- Updated Conda environment notes from
spyglass-position
tospyglass-dlc
- Reset
execution_count
tonull
and cleared cell outputs - Fixed
NameError: model_key
by creating aDLCPoseEstimationSelection
instance before callinginsert_estimation_task
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
notebooks/21_DLC.ipynb | Environment note update; cleared outputs/execution counts |
notebooks/22_DLC_Loop.ipynb | Same notebook-level updates + instantiation fix for pose estimation |
"source": [ | ||
"### Body Parts" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This markdown header appears twice in succession. Consider removing the duplicate to avoid repetition.
"source": [ | |
"### Body Parts" | |
] | |
"source": [] |
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
+ Coverage 67.21% 67.45% +0.23%
==========================================
Files 98 98
Lines 12272 12290 +18
==========================================
+ Hits 8249 8290 +41
+ Misses 4023 4000 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context. Please list issues fixed or closed by
This PR.
/spyglass/notebooks/21_DLC.ipynb
: updated that the env used isspyglass-dlc
which is installed fromenvironment_dlc.yml
; fixes the error in pose estimation section where'model_key' is not defined
by creating an instance ofdlc_pose_estimation
before creating variablepose_estimation_key
/spyglass/notebooks/22_DLC_Loop.ipynb
: same as aboveChecklist:
CITATION.cff
alter
snippet for release notes.CHANGELOG.md
with PR number and description.