8000 More recompute fixes by CBroz1 · Pull Request #1340 · LorenFrankLab/spyglass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More recompute fixes #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

More recompute fixes #1340

wants to merge 5 commits into from
+334 −74

Conversation

CBroz1
Copy link
Member
@CBroz1 CBroz1 commented Jun 28, 2025 •
edited
Loading

Description

  • This makes a change to v0.RecordingRecompute to add err_msg, but this table was not included in the previous release and arguably does not require an alter in the release notes
  • common_user.py: add tracking of editable installs in user environments
  • spikesorting_recompute.py and recompute.py:
    • ensure deletion of matched files
    • add util for getting size of files subset
    • skip checks with previous successful attempt
    • allow force of selection insert. remove gatekeep check at recompute
  • spikesorting_recording.py:
    • ignore missing files when updating ids
    • reduce verbosity on saving recordings

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • Yes. This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

CBroz1 added 5 commits May 20, 2025 09:40
@CBroz1
Fix update process
0581add
@CBroz1
Update changelog
b89a50a
@CBroz1
Fetch upstream
a430fd1
@CBroz1
See details
7df163d 
- Yes, this makes a change to v0.RecordingRecompute to add err_msg
- `common_user.py`: add tracking of editable installs in user environments
- `spikesorting_recompute.py` and `recompute.py`:
  - ensure deletion of matched files
  - add util for getting size of files subset
  - skip checks with previous successful attempt
  - allow force of selection insert. remove gatekeep check at recompute
- `spikesorting_recording.py`:
  - ignore missing files when updating ids
  - reduce verbosity on saving recordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CBroz1
0