8000 Do not use isDepot check in Exchange by N-Wouda · Pull Request #699 · PyVRP/PyVRP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not use isDepot check in Exchange #699

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2024
Merged

Do not use isDepot check in Exchange #699

merged 1 commit into from
Nov 17, 2024

Conversation

N-Wouda
Copy link
Member
@N-Wouda N-Wouda commented Nov 17, 2024 •
edited
Loading

This PR is part of #416.

Notes:

Please read our contributing guidelines first.
In particular:

  • You must add tests when making code changes.
    This keeps the code coverage level up, and helps ensure the changes work as intended.
  • When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
  • Docstring additions must render correctly, including escapes and LaTeX.
  • Finally, it is essential that all contributions in this PR are license-compatible with PyVRP's MIT license.
    Please check that this PR can be included into PyVRP under the MIT license.

@N-Wouda N-Wouda changed the title Do not isDepot check in Exchange Do not use isDepot check in Exchange Nov 17, 2024
@codecov Codecov
Copy link
codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (026ecf7) to head (f836c3e).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files          76       76           
  Lines        3745     3745           
  Branches      992      992           
=======================================
  Hits         3622     3622           
  Misses         14       14           
  Partials      109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #699 will not alter performance

Comparing do-not-use-isdepot-check-in-exchange (f836c3e) with main (026ecf7)

Summary

✅ 42 untouched benchmarks

@N-Wouda N-Wouda merged commit 8046cd0 into main Nov 17, 2024
8 of 9 checks passed
@N-Wouda N-Wouda deleted the do-not-use-isdepot-check-in-exchange branch November 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@N-Wouda
0