8000 feat: Implement better get_or_fetch by Lumabots · Pull Request #2776 · Pycord-Development/pycord · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Implement better get_or_fetch #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

feat: Implement better get_or_fetch #2776

wants to merge 70 commits into from

Conversation

Lumabots
Copy link
Contributor
@Lumabots Lumabots commented May 3, 2025 •
edited
Loading

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters). Implement better get_or_fetch #1856
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lumabots added 5 commits May 3, 2025 00:37
@Lumabots
Update CHANGELOG.md
dce0206 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
add a get or fetch to guild
b2b8884 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Implement better get_or_fetch using typevar and object
8f9a257 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
shortcut for get or fetch
9f6219c 
Signed-off-by: Lum
8000
ouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Update CHANGELOG.md
4af5149 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots Lumabots requested a review from a team as a code owner May 3, 2025 20:58
@pullapprove4 pullapprove4 bot requested a review from VincentRPS May 3, 2025 20:58
@Lumabots
Copy link
Contributor Author
Lumabots commented May 3, 2025

feat from #1856

Paillat-dev
Paillat-dev reviewed May 3, 2025
View reviewed changes
Lumabots and others added 5 commits May 4, 2025 01:30
@Lumabots
usage of subclass
c0689cc 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
b20822a
@Lumabots
add get_emoji method
4a363f5 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
c3a7dd2
@Lumabots
add get_or_fetch_emoji method
e614c47 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author
Lumabots commented May 3, 2025

still not ready have some bug like : NameError: name 'VoiceChannel' is not defined
ig because of the type checking, i'll have to find a way to import it without circular import

@Paillat-dev
Copy link
Contributor

@Lumabots You can import it inside of the function where 8000 you use it directly instead of importing it at the top

@Lumabots
Copy link
Contributor Author
Lumabots commented May 3, 2025

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

Well ig the issue come from the definition for the typevar, so will that resolve it ?

Lumabots and others added 8 commits May 4, 2025 18:22
@Lumabots
shortcut getorfetch client + removal of get_or_fetch user in favor of…
0c0a042 
… get_or_fetch shortcut

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
466e41b
@Lumabots
Update utils.py
388a234 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Update guild.py
9737f69 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Update client.py
656de14 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
461eab7
@Lumabots
Update utils.py
b6f8878 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
f2a7d72
@Lumabots
Copy link
Contributor Author
Lumabots commented May 4, 2025

should be ready for review

@Lumabots
Copy link
Contributor Author
Lumabots commented May 4, 2025

just need to specify that this is breaking inside the changelog cos of modification of get_or_fetch and removal of get_or_fetch_user

@Lumabots Lumabots requested a review from plun1331 May 9, 2025 21:05
NeloBlivion
NeloBlivion reviewed May 15, 2025
View reviewed changes
@Lumabots
Update CHANGELOG.md
0ffaa4b 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots Lumabots requested a review from NeloBlivion May 15, 2025 18:44
Paillat-dev
Paillat-dev suggested changes May 16, 2025
View reviewed changes
Lumabots and others added 3 commits May 17, 2025 13:28
@Lumabots
Update CHANGELOG.md
b8c7f7f 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
53dc93c
@Lumabots
Update CHANGELOG.md
6d89376 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots Lumabots requested a review from Paillat-dev May 17, 2025 10:30
Paillat-dev
Paillat-dev suggested changes May 17, 2025
View reviewed changes
@Lumabots @Paillat-dev
Update CHANGELOG.md
2abfba2 
Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author
Lumabots commented Jun 4, 2025

maybe i could also handle in case the id is none by just retuning None, this could help as a helper fonction to not have to check with a if ... is not None, what are your thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soheab Soheab Soheab left review comments

@Paillat-dev Paillat-dev Paillat-dev approved these changes

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@plun1331 plun1331 Awaiting requested review from plun1331

@NeloBlivion NeloBlivion Awaiting requested review from NeloBlivion

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
PA: All Contributors pending PA: Maintainers pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lumabots @Paillat-dev @plun1331 @Soheab @NeloBlivion
0