8000 Update the PyROS Separation Priority Ordering Interface by shermanjasonaf · Pull Request #3581 · Pyomo/pyomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the PyROS Separation Priority Ordering Interface #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

shermanjasonaf
Copy link
Contributor
@shermanjasonaf shermanjasonaf commented Apr 28, 2025

Summary/Motivation:

Update the PyROS solver interface for specification of constraint separation priorities.

Changes proposed in this PR:

  • Add support for detection of separation priorities from Suffix components with local name "pyros_separation_priority"
  • Deprecate the optional argument separation_priority_order
  • Acknowledge, where applicable, separation priorities mapped to (the name of) any Var or Constraint component declared on the model. Thus, for example, constraints derived from Var bound specifications can be prioritized by mapping priorities to Var components
  • Allow None to be specified as a priority for equality and inequality constraints that are not to be robustly enforced. These constraints are enforced subject to only the nominal uncertain parameter realization, and are therefore excluded from the separation problems. Note also that equality constraints with a priority of None are, therefore, not reformulated via coefficient matching or discretization, where otherwise applicable
  • Add to the PyROS online documentation a section that explains the interface for specifying constraint separation priorities

TODO

  • Update version number, changelog (including deprecation warning and online docs logging example)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho requested review from jsiirola and blnicho April 29, 2025 18:43
@shermanjasonaf
Copy link
Contributor Author

@jas-yao @natalieisenberg

@mrmundt mrmundt self-requested a review June 17, 2025 19:24
Copy link
Member
@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Copy link
Contributor
@emma58 emma58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (dc503c2) to head (7b04294).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         888      888           
  Lines      102347   102391   +44     
=======================================
+ Hits        91009    91054   +45     
+ Misses      11338    11337    -1     
Flag Coverage Δ
builders 26.67% <14.03%> (-0.02%) ⬇️
default 85.51% <100.00%> (?)
expensive 34.04% <14.03%> (?)
linux 86.73% <100.00%> (-1.95%) ⬇️
linux_other 86.73% <100.00%> (+<0.01%) ⬆️
osx 83.03% <100.00%> (+<0.01%) ⬆️
win 84.95% <100.00%> (+<0.01%) ⬆️
win_other 84.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0