feat: Update device manager and device to establish an MQTT subscription #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds MQTT subscription support per device by introducing an MQTT “channel” abstraction, integrating it into both the device manager and individual device objects, and updating the CLI to leverage the new manager.
- Introduce
MqttChannelfor subscribing/unsubscribing to device-specific topics - Wire up MQTT sessions in
DeviceManagerandRoborockDeviceto manage connections and clean up on close - Refactor the CLI to use
create_device_managerand ensure graceful shutdown of MQTT
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/devices/test_mqtt_channel.py | Add tests for MqttChannel.subscribe behavior |
| tests/devices/test_device_manager.py | Ensure close() is called on the manager in tests |
| tests/devices/test_device.py | Test RoborockDevice.connect / close integration with channel |
| roborock/devices/mqtt_channel.py | New class to wrap MQTT subscribe/unsubscribe for a device |
| roborock/devices/device_manager.py | Pass through MQTT session, establish channels on discovery, add close() |
| roborock/devices/device.py | Add connect/close methods to manage MQTT subscriptions |
| roborock/cli.py | Refactor CLI to use create_device_manager and clean shutdown |
Comments suppressed due to low confidence (2)
roborock/devices/device_manager.py:96
- The constructor for
RoborockApiClientoriginally accepted(email, user_data). Confirm that droppinguser_datamatches the new API signature or update accordingly.
client = RoborockApiClient(email)
tests/devices/test_mqtt_channel.py:47
- Add a test case to verify that calling
subscribetwice raises the expectedValueErrorwhen already subscribed, as described in the method docstring.
async def test_mqtt_channel() -> None:
allenporter
commented
Jul 2, 2025
allenporter
commented
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the device manager and device to establish an Mqtt "channel" which is the device-specific subscription in the mqtt session. The channel will be used for decoding messages and sending/receiving RPCs.
Lots of future work needed here including: