Check FireTick during match load and start #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
May 27, 2021
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
May 28, 2021
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
Jun 8, 2021
core/src/main/java/tc/oc/pgm/gamerules/GameRulesMatchModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
…unlocktime calcluation in PGMListener Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
Jun 12, 2021
core/src/main/java/tc/oc/pgm/gamerules/GameRulesMatchModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
|
This PR now adds gamerules set by |
Pablete1234
reviewed
Jul 15, 2021
core/src/main/java/tc/oc/pgm/gamerules/GameRulesMatchModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
Aug 1, 2021
core/src/main/java/tc/oc/pgm/gamerules/GameRulesMatchModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
|
Currently in this PR maps that have doDayLightCycle set to true in the gamerule XML do not get the sun moving. Intercept specifically has this on. <gamerules>
<doDaylightCycle>true</doDaylightCycle>
</gamerules> |
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
|
This PR is in working order now. |
Pablete1234
approved these changes
Sep 4, 2021
Electroid
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was helping @technodono find out why The Dropper Community map was damaged, I discovered that fire spreads before the match starts. This PR fixes this simple bug to make it consistent with other world events, like PGM locking mob movement and time. DoFireTick will now default to on (as it always has) when the match starts.