Map visibility feature #883
Conversation
* Allows for maps to be hidden from public viewing Signed-off-by: applenick <applenick@users.noreply.github.com>
|
What's the intended purpose of this? What use cases? I can't really think of any off the top of my head so this just seems like unessential code burden. I'd stick with a command that's specific to maps as setvisibility and togglevisibility are bit generic. |
|
I'm not sure exactly what the use of this is,, but, wouldn't it make more sense to just bring back That way you could simply hide maps in I don't really get why it'd be something to store in a DB instead of it being dictated by the XML of the map |
| map.visibility.hidden = hidden | ||
|
|
||
| map.visibility.shown = shown |
There was a problem hiding this comment.
These strings already exist as
setting.visibility.shown
setting.visibility.hidden
maybe port to misc?
| throws CommandException { | ||
| List<MapVisibility> hiddenMaps = PGM.get().getDatastore().getHiddenMaps(); | ||
|
|
||
| int resultsPerPage = 8; |
There was a problem hiding this comment.
This looks like its never changed, maybe change it to a static final variable in the class-scope so it can be used in MapCommand as well?
| .clickEvent(ClickEvent.runCommand("/map " + map.getMap().getName())) | ||
| .hoverEvent( | ||
| HoverEvent.showText( |
There was a problem hiding this comment.
maybe import static runCommand and showText?
|
I'm obviously not involved with PGM development directly, but via map development on OCC. I also see very little, if any, applications for this as it currently stands.
This seems more useful to me as there are a few applications for the |
|
Sorry for the lack of updates, I spoke with Pablo the other day and will convert this feature to instead use the |
|
Closed in favor of #891 |
Map Visibility Feature
Discussed this with @Electroid yesterday. Basically allows for loaded maps to be hidden from public viewing.
Commands:
/hiddenmaps- View a list of hidden maps/mapvisibility [map]- Toggle thehiddenstatus of the provided mapAt the moment hidden maps are only hidden from being visible via
/maps, however this will be used more widely for other upcoming changes.Preview
hidden-maps.mp4
Suggestions
Could use some suggestions on whether
/hiddenmapsshould be its own dedicated command, or if it should be implemented as a flag under/mapsfor example/maps -h.Also maybe
/mapvisibilityshould be/setvisibilityor/togglevisibility? UnsureSigned-off-by: applenick applenick@users.noreply.github.com