8000 Bump ViaVersion to 4.0.1 by applenick · Pull Request #905 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump ViaVersion to 4.0.1 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2021
Merged

Bump ViaVersion to 4.0.1 #905

merged 2 commits into from
Jul 27, 2021

Conversation

applenick
Copy link
Member

This PR updates ViaVersion from 3.0.2 -> 4.0.1

Signed-off-by: applenick applenick@users.noreply.github.com

@applenick
Bump ViaVersion to 4.0.1
49a7f9d 
Signed-off-by: applenick <applenick@users.noreply.github.com>
@applenick applenick requested a review from Electroid as a code owner July 26, 2021 19:46
@applenick applenick mentioned this pull request Jul 26, 2021
Merged
@calcastor
Copy link
Contributor

ViaVersion has a legacy API that redirects any references to us.myles.ViaVersion to the new API. Maybe it would be best to keep that to allow servers to use older versions of ViaVersion et al. if necessary, given bugs such as dropped items showing as stone for all 1.7 users with upstream ViaRewind for instance?

@applenick
Copy link
Member Author

ViaVersion has a legacy API that redirects any references to us.myles.ViaVersion to the new API. Maybe it would be best to keep that to allow servers to use older versions of ViaVersion et al. if necessary, given bugs such as dropped items showing as stone for all 1.7 users with upstream ViaRewind for instance?

Oh shoot! Is that a thing?

This was mainly to fix the compile error in #904

@applenick
Use legacy import for maximum compatibility
9e2e039 
Signed-off-by: applenick <applenick@users.noreply.github.com>
@applenick
Copy link
Member Author
applenick commented Jul 26, 2021 •
edited
Loading

Thanks @calcastor, found the api-legacy package! That was neat to learn. All fixed now 👍

@calcastor
Copy link
Contributor
calcastor commented Jul 26, 2021 •
edited
Loading

ViaVersion has a legacy API that redirects any references to us.myles.ViaVersion to the new API. Maybe it would be best to keep that to allow servers to use older versions of ViaVersion et al. if necessary, given bugs such as dropped items showing as stone for all 1.7 users with upstream ViaRewind for instance?

Oh shoot! Is that a thing?

This was mainly to fix the compile error in #904

That is my understanding of what this does at least. I've been modifying the pom.xml to reference the latest version of ViaVersion when I build locally, but haven't been updating ViaUtils and it has seemed to work 100% as intended. I'd assume that updating ViaUtils to not use the legacy API might break it when using older versions of ViaVersion.

edit: see above I guess I missed a comment when writing this out haha!

@Electroid Electroid merged commit 6a5120b into PGMDev:dev Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Awaiting requested review from Electroid

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@applenick @calcastor @Electroid
0