Check objective visibility on displaying mode change messages #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
Nov 23, 2021
There was a problem hiding this comment.
Add a getAffectedObjectives or similar to the event, and use that on the event handler to find if any are non-hidden
Trying to iterate all objectives here is a mess
Alternatively you can add a boolean show field to the event, which the handler sets to true if any core/destroyable changed has show=true
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
requested changes
Nov 24, 2021
There was a problem hiding this comment.
https://github.com/PGMDev/PGM/blob/dev/core/src/main/java/tc/oc/pgm/core/CoreMatchModule.java#L155
Edit both of those event handlers, make them HIGHEST priority instead of monitor, and make it so:
if (core.isVisible()) event.setVisible(true);, and similarly for monuments
Make ObjectiveModeEvent's visible non-final, and add the setVisible setter
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Signed-off-by: Patrick <cowinkkeydinkinc@gmail.com>
Pablete1234
approved these changes
Nov 25, 2021
Electroid
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an ongoing issue that started strangely happening without any idea how. The mode change message in the chat would be repeated for each objective that changed mode, and would still appear even when the objective's
showattribute is false. This adds a proper checker to make sure the mode message is only sent out once per mode change, and that it won't send the message if all objectives that use the mode hasshow=false. I first seen this yesterday when the message repeated 8 times on Death DeNile.From the code this issue should've been a problem for a long time but has seemed to popup about two weeks ago 🤷♂️