#939 Bring back PGM objective filters #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chiddy <chiddy@chiddy.xyz>
b008bde to
2d4f331
Compare
here's hoping the "commit suggestion" button doesn't screw me over Co-authored-by: KingOfSquares <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: chiddy <chiddy@chiddy.xyz>
b52697f to
65e3839
Compare
|
a sad reminder that "commit suggestion" does not sign off the commit... |
|
a sad reminder that "commit suggestion" does not enforce formatting, and that line is too long to pass so you'll need to run the formatter |
Signed-off-by: chiddy <chiddy@chiddy.xyz>
|
Sad GitHub moment 😔 |
Pablete1234
approved these changes
Jan 11, 2022
Electroid
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #939
tested with a locally modified ballot box(for
completedtag) and cherokee (forcapturedtag)while i did only test with control points, considering it's just calling the same
GoalFilterconstructor with set values it should function the same, i was unsure whether to throw an exception for attributes thatcompletedandcaptureddon't support but decided it realistically wasn't necessary.