8000 Structures by KingOfSquares · Pull Request #1029 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Structures #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 10 commits into from
Nov 4, 2022
Merged

Structures #1029

merged 10 commits into from
Nov 4, 2022

Conversation

KingOfSquares
Copy link
Contributor
@KingOfSquares KingOfSquares commented Jul 10, 2022 •
edited
Loading

put this draft up to get feedback on design and naming(please help)

Not yet ready for merge since I want to test more(structures are scary)

applenick
applenick reviewed Jul 10, 2022
View reviewed changes
@KingOfSquares KingOfSquares marked this pull request as ready for review July 26, 2022 12:51
@KingOfSquares KingOfSquares requested a review from Electroid as a code owner July 26, 2022 12:51
Pablete1234
Pablete1234 requested changes Jul 30, 2022
View reviewed changes
@KingOfSquares
Copy link
Contributor Author

@Pablete1234 Pablete1234 added feature New feature or request reintroduce Reintroduces a feature that was removed labels Aug 29, 2022
@Electroid Electroid force-pushed the dev branch 2 times, most recently from 20c50fe to d978236 Compare October 8, 2022 23:40
@Pablete1234 Pablete1234 mentioned this pull request Oct 13, 2022
Open
20 tasks
KingOfSquares and others added 7 commits October 22, 2022 22:54
@KingOfSquares @Pablete1234
initial draft for structures
269cb05 
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@KingOfSquares @Pablete1234
optimize, fix and format structures
762c429 
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@KingOfSquares @Pablete1234
Fix unecessary creation of SnapshotMatchModule if structures and rene…
04bda72 
…wables is not present

Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@KingOfSquares @Pablete1234
Move some code in StructureMatchModule
8d7b40b 
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@KingOfSquares @Pablete1234
format
ada1b07 
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@KingOfSquares @Pablete1234
WIP changes
1643738 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234
Cleanup and finish structures
18831cb 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234
Make static filter dynamic
938c90b 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234
Optimizations & minor final touchups
e639ec4 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Pablete1234
Pablete1234 previously approved these changes Oct 23, 2022
View reviewed changes
@KingOfSquares
Fix some naming and javadocs
72bd54e 
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
@Pablete1234 Pablete1234 added the ready PR is ready to merge label Nov 1, 2022
Electroid
Electroid approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member
@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Excited to bring it back!

@Electroid Electroid merged commit 50e166a into PGMDev:dev Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applenick applenick applenick left review comments

@Electroid Electroid Electroid approved these changes

@Pablete1234 Pablete1234 Pablete1234 left review comments

Assignees
No one assigned
Labels
feature New feature or request ready PR is ready to merge reintroduce Reintroduces a feature that was removed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KingOfSquares @Electroid @applenick @Pablete1234
0

btw, this branch is blocked until I finish lootables(commissioned work)