-
Notifications
You must be signed in to change notification settings - Fork 96
Structures #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Structures #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d22335
to
78e32a0
Compare
applenick
reviewed
Jul 10, 2022
Pablete1234
requested changes
Jul 30, 2022
8000
btw, this branch is blocked until I finish lootables(commissioned work) |
20c50fe
to
d978236
Compare
638c9d3
to
6b5758e
Compare
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
…wables is not present Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
6b5758e
to
18831cb
Compare
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Pablete1234
previously approved these changes
Oct 23, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Electroid
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Excited to bring it back!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
ready
PR is ready to merge
reintroduce
Reintroduces a feature that was removed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put this draft up to get feedback on design and naming(please help)
Not yet ready for merge since I want to test more(structures are scary)