8000 Fix missing dependency on jar by Pablete1234 · Pull Request #1035 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing dependency on jar #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

Fix missing dependency on jar #1035

merged 1 commit into from
Jul 17, 2022

Conversation

Pablete1234
Copy link
Member

Running PGM from the IDE works just fine, but compiling a jar and trying to run it is missing a dependency that isn't being shaded ATM. This is a side effect from pools rework that were recently merged.

@Pablete1234
Fix required dependency not being shaded
c3761ea 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234 Pablete1234 requested a review from Electroid as a code owner July 17, 2022 01:05
@Pablete1234 Pablete1234 added bug Something isn't working urgent Breaks the plugin labels Jul 17, 2022
@Electroid Electroid merged commit 15ea3a4 into dev Jul 17, 2022
@Electroid Electroid deleted the fix-dep-shade branch July 17, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working urgent Breaks the plugin
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pablete1234 @Electroid
0