Optimize scoreboard & allow ratelimit #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows scoreboard being rate-limiting under stress situations, in a similar fashion to tablist, where if the renders take long or if the server runs low on TPS it will debounce for longer periods (up to 1 second). This reuses logic originally used in tablist to debounce (in that case, up to 5s), which has now been put in a RateLimiter util, and reused in both places.
The reason for this change is that specifically for ffa, where sidebar renders player names, it can take a non-trivial amount of text serialization/deserialization, which can be costly. Additionally, names have been changed to use the simpler just-color version of the name, which should be faster than the full version with flairs and hover events etc.