8000 Implement after filter by Pablete1234 · Pull Request #1075 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement after filter #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Implement after filter #1075

merged 1 commit into from
Oct 10, 2022

Conversation

Pablete1234
Copy link
Member
@Pablete1234 Pablete1234 commented Oct 10, 2022 •
edited
Loading

Similar to the countdown filter, after will start matching a duration after the child starts matching:

<after duration="5s">
  <cuboid .../>
</after>

The filter will start matching players after they enter and stay in the cuboid for 5s.

This is feature-wise identical to:

<all>
  <cuboid .../>
  <not>
    <countdown duration="5s">
      <cuboid .../>
    </countdown>
  </not>
</all>

It also solves countdowns (and after) not supporting filter references neither as children nor as an attribute, so these are now possible and weren't before:

<countdown filter="some-other-filter" duration="5s"/>
<countdown duration="5s">
  <filter id="some-other-filter"/>
</countdown>

The PR has been tested and works as intended.

@Pablete1234
Implement after filter
bf154d2 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234 Pablete1234 added bug Something isn't working feature New feature or request labels Oct 10, 2022
@Electroid Electroid merged commit c9e7d58 into dev Oct 10, 2022
@Electroid Electroid deleted the after-filter branch October 10, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pablete1234 @Electroid
0