8000 Fix monostable filter scope forward reference by Pablete1234 · Pull Request #1078 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix monostable filter scope forward reference #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix monostable filter scope forward reference #1078

merged 1 commit into from
Oct 10, 2022

Conversation

Pablete1234
Copy link
Member
@Pablete1234 Pablete1234 commented Oct 10, 2022 •
edited
Loading

Monotsable filters (countdown and after) are failing when using forward references to filters not yet defined:

<!-- Has always been valid, has always errored out -->
<countdown duration="5s"> 
  <all>
    <filter id="defined-later"/>
  </all>
</countdown>

<!-- These are only valid since PR #1075, as direct child used to not support references -->
<after duration="5s"> 
    <filter id="defined-later"/>
</after>
<after duration="5s" filter="defined-later"/>

<!-- Defined later, so the above filters can't check the scope. Works fine if this is declared first -->
<variable id="defined-later" var="a">0</variable>

This resolves it by moving the scope-getting to the reactor, at match time instead of parse time.

This PR has been tested and works as intended

@Pablete1234
Fix monostable filter scope forward reference
d681b44
9350 
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
@Pablete1234 Pablete1234 added the bug Something isn't working label Oct 10, 2022
@Electroid Electroid merged commit 86ed051 into dev Oct 10, 2022
@Electroid Electroid deleted the monostable-scope-fix branch October 10, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pablete1234 @Electroid
0