Implement bossbars for cooldown filter #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
2abb4f4 to
648b42e
Compare
Electroid
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements the feature from 1.11+ PGM where
<countdown>filters could include amessageattribute, and show as a bossbar. Additionally, the new<after>filter also has the same functionality.Example (assumes a previous filter other-filter exists):
<after message="Something will happen in {0}" duration="30s" filter="other-filter" />The literal
{0}will be replaced by the remaining time.Additionally, it does a bit of a cleanup pass on time components, changing the return types from builders to components.